-
Notifications
You must be signed in to change notification settings - Fork 23
Remove cython pinning to < 3.1
#2443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Array API standard conformance tests for dpnp=0.18.0dev2=py312he4f9c94_10 ran successfully. |
vlad-perevezentsev
approved these changes
May 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @antonwolfy !
github-actions bot
added a commit
that referenced
this pull request
May 13, 2025
This PR reverts cython pinning added in #2441 which was added to unblock CI due to compilation error: ```bash $SRC_DIR/_skbuild/linux-x86_64-3.9/cmake-build/dpnp/dpnp_utils/dpnp_algo_utils.cxx:28898:36: error: use of undeclared identifier '__pyx_convert__to_py___pyx_ctuple_4f2d56__4dpnp_9dpnp_algo_9dpnp_algo_enum__space_DPNPFu__etc'; did you mean '__pyx_ctuple_4f2d56__4dpnp_9dpnp_algo_9dpnp_algo_enum__space_DPNPFu__etc'? 28898 | __Pyx_TraceReturnCValue(__pyx_r, __pyx_convert__to_py___pyx_ctuple_4f2d56__4dpnp_9dpnp_algo_9dpnp_algo_enum__space_DPNPFu__etc, 21, 0, __PYX_ERR(0, 466, __pyx_L1_error)); | ^ $SRC_DIR/_skbuild/linux-x86_64-3.9/cmake-build/dpnp/dpnp_utils/dpnp_algo_utils.cxx:2104:89: note: '__pyx_ctuple_4f2d56__4dpnp_9dpnp_algo_9dpnp_algo_enum__space_DPNPFu__etc' declared here 2104 | typedef struct __pyx_ctuple_4f2d56__4dpnp_9dpnp_algo_9dpnp_algo_enum__space_DPNPFu__etc __pyx_ctuple_4f2d56__4dpnp_9dpnp_algo_9dpnp_algo_enum__space_DPNPFu__etc; | ^ $SRC_DIR/_skbuild/linux-x86_64-3.9/cmake-build/dpnp/dpnp_utils/dpnp_algo_utils.cxx:28898:36: error: use of undeclared identifier '__pyx_convert__to_py___pyx_ctuple_4f2d56__4dpnp_9dpnp_algo_9dpnp_algo_enum__space_DPNPFu__etc'; did you mean '__pyx_ctuple_4f2d56__4dpnp_9dpnp_algo_9dpnp_algo_enum__space_DPNPFu__etc'? 28898 | __Pyx_TraceReturnCValue(__pyx_r, __pyx_convert__to_py___pyx_ctuple_4f2d56__4dpnp_9dpnp_algo_9dpnp_algo_enum__space_DPNPFu__etc, 21, 0, __PYX_ERR(0, 466, __pyx_L1_error)); | ^ $SRC_DIR/_skbuild/linux-x86_64-3.9/cmake-build/dpnp/dpnp_utils/dpnp_algo_utils.cxx:2104:89: note: '__pyx_ctuple_4f2d56__4dpnp_9dpnp_algo_9dpnp_algo_enum__space_DPNPFu__etc' declared here 2104 | typedef struct __pyx_ctuple_4f2d56__4dpnp_9dpnp_algo_9dpnp_algo_enum__space_DPNPFu__etc __pyx_ctuple_4f2d56__4dpnp_9dpnp_algo_9dpnp_algo_enum__space_DPNPFu__etc; | ^ 2 errors generated. ``` d75c842
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts cython pinning added in #2441 which was added to unblock CI due to compilation error:
The error is caused by cython issue when line tracing is enabled and if there is ctuple returned.
It is proposed to disable line tracing per affected function to mitigate the compilation error.