Skip to content

Temporary disable failing tests for NaN input passed to dpnp.linalg.cond #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025
Merged

Temporary disable failing tests for NaN input passed to dpnp.linalg.cond #2454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e8afc4
Temporary disable failing test for NaN input passed to dpnp.linalg.cond
antonwolfy May 15, 2025
14bdacc
Improve error tracing by adding missing space
antonwolfy May 15, 2025
e91fc7a
Merge branch 'master' into disable-failing-cond-tests-on-windows
antonwolfy May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dpnp/backend/extensions/lapack/getrf_batch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ static sycl::event getrf_batch_impl(sycl::queue &exec_q,
auto error_matrices_ids_size = error_matrices_ids.size();
auto dev_info_size = static_cast<std::size_t>(py::len(dev_info));
if (error_matrices_ids_size != dev_info_size) {
throw py::value_error("The size of `dev_info` must be equal to" +
throw py::value_error("The size of `dev_info` must be equal to " +
std::to_string(error_matrices_ids_size) +
", but currently it is " +
std::to_string(dev_info_size) + ".");
Expand Down
2 changes: 1 addition & 1 deletion dpnp/backend/extensions/lapack/getri_batch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ static sycl::event getri_batch_impl(sycl::queue &exec_q,
auto error_matrices_ids_size = error_matrices_ids.size();
auto dev_info_size = static_cast<std::size_t>(py::len(dev_info));
if (error_matrices_ids_size != dev_info_size) {
throw py::value_error("The size of `dev_info` must be equal to" +
throw py::value_error("The size of `dev_info` must be equal to " +
std::to_string(error_matrices_ids_size) +
", but currently it is " +
std::to_string(dev_info_size) + ".");
Expand Down
10 changes: 8 additions & 2 deletions dpnp/tests/test_linalg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from dpctl.utils import ExecutionPlacementError
from numpy.testing import (
assert_allclose,
assert_almost_equal,
assert_array_equal,
assert_equal,
assert_raises,
Expand All @@ -20,12 +19,13 @@
assert_dtype_allclose,
generate_random_numpy_array,
get_all_dtypes,
get_complex_dtypes,
get_float_complex_dtypes,
get_integer_float_dtypes,
has_support_aspect64,
is_cpu_device,
is_cuda_device,
is_gpu_device,
is_win_platform,
numpy_version,
)
from .third_party.cupy import testing
Expand Down Expand Up @@ -334,6 +334,12 @@ def test_nan(self, p):
# while OneMKL returns nans
if is_cuda_device() and p in [-dpnp.inf, -1, 1, dpnp.inf, "fro"]:
pytest.skip("Different behavior on CUDA")
elif (
is_gpu_device()
and is_win_platform()
and p in [-dpnp.inf, -1, 1, dpnp.inf, "fro"]
):
pytest.skip("SAT-7966")
a = generate_random_numpy_array((2, 2, 2, 2))
a[0, 0] = 0
a[1, 1] = 0
Expand Down
Loading