Skip to content

Enabled tests previously muted for numpy 2.3 #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

Enabled tests previously muted for numpy 2.3 #2495

merged 1 commit into from
Jun 23, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jun 23, 2025 •
edited
Loading

The new numpy release 2.3.1 has been published which includes the fix for numpy#29164.
That PR enables the previously muted tests for numpy 2.3.1 in #2477.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this Jun 23, 2025
@antonwolfy antonwolfy added this to the 0.18.1 release milestone Jun 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2495/index.html

@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.19.0dev0=py312h509198e_20 ran successfully.
Passed: 1231
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.863%. remained the same
when pulling d32e5c6 on enable-muted-tests-for-numpy-2.3.1
into cedd0d1 on master.

vlad-perevezentsev
vlad-perevezentsev approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 278cf42 into master Jun 23, 2025
84 of 88 checks passed
@antonwolfy antonwolfy deleted the enable-muted-tests-for-numpy-2.3.1 branch June 23, 2025 12:37
antonwolfy added a commit that referenced this pull request Jun 23, 2025
@antonwolfy
Enabled tests previously muted for numpy 2.3 (#2495)
84c031c 
The new numpy release `2.3.1` has been published which includes the fix
for numpy#29164.
That PR enables the previously muted tests for numpy 2.3.1 in #2477.
github-actions bot added a commit that referenced this pull request Jun 23, 2025
@github-actions
Enabled tests previously muted for numpy 2.3 (#2495)
3bf1548 
The new numpy release `2.3.1` has been published which includes the fix
for numpy#29164.
That PR enables the previously muted tests for numpy 2.3.1 in #2477. 278cf42
antonwolfy added a commit that referenced this pull request Jun 23, 2025
@antonwolfy
Backport gh-2495 (#2497)
9c29fe7 
This PR backports of #2495from development branch to
`maintenance/0.18.x`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vtavana vtavana Awaiting requested review from vtavana

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

0.18.1 release

Development

Successfully merging this pull request may close these issues.

3 participants

@antonwolfy @coveralls @vlad-perevezentsev