Skip to content

Fix compilation warnings #2517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2025
Merged

Fix compilation warnings #2517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2eb675
Fix compilation warnings
antonwolfy Jul 7, 2025
98b2636
Add PR to the changelog
antonwolfy Jul 7, 2025
815383a
Applied pre-commit
antonwolfy Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* Updated existing GitHub workflows to add testing with Python 3.13 [#2510](https://github.com/IntelPython/dpnp/pull/2510)
* Aligned the license expression with `PEP-639` [#2511](https://github.com/IntelPython/dpnp/pull/2511)
* Bumped oneMKL version up to `v0.8` [#2514](https://github.com/IntelPython/dpnp/pull/2514)
* Removed the use of class template argument deduction for alias template to conform to the C++17 standard [#2517](https://github.com/IntelPython/dpnp/pull/2517)

### Deprecated

Expand Down
9 changes: 6 additions & 3 deletions dpnp/backend/extensions/statistics/histogram.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,12 +139,14 @@ struct HistogramF
auto dispatch_edges = [&](uint32_t local_mem, const auto &weights,
auto &hist) {
if (device.is_gpu() && (local_mem >= bins_count + 1)) {
auto edges = CachedEdges(bins_edges, bins_count + 1, cgh);
auto edges =
CachedEdges<BinsT>(bins_edges, bins_count + 1, cgh);
submit_histogram(in, size, dims, WorkPI, hist, edges,
weights, nd_range, cgh);
}
else {
auto edges = UncachedEdges(bins_edges, bins_count + 1, cgh);
auto edges =
UncachedEdges<BinsT>(bins_edges, bins_count + 1, cgh);
submit_histogram(in, size, dims, WorkPI, hist, edges,
weights, nd_range, cgh);
}
Expand All @@ -165,7 +167,8 @@ struct HistogramF
}
else {
auto hist = HistGlobalMemory<HistType>(out);
auto edges = UncachedEdges(bins_edges, bins_count + 1, cgh);
auto edges =
UncachedEdges<BinsT>(bins_edges, bins_count + 1, cgh);
submit_histogram(in, size, dims, WorkPI, hist, edges,
weights, nd_range, cgh);
}
Expand Down
Loading