Skip to content

Implement dpnp.linalg.lu_factor batch inputs #2565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 29, 2025
Merged

Implement dpnp.linalg.lu_factor batch inputs #2565

merged 12 commits into from
Aug 29, 2025

Conversation

vlad-perevezentsev
Copy link
Contributor

This PR suggests extending dpnp.linalg.lu_factor() #2557 for batch arrays

In addition, this PR includes:

  1. An updated implementation of getrf_batch to support non-square matrices.
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Aug 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 21, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 21, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.19.0dev3=py313h509198e_24 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

ndgrigorian
ndgrigorian reviewed Aug 21, 2025
View reviewed changes
ndgrigorian
ndgrigorian reviewed Aug 22, 2025
View reviewed changes
ndgrigorian
ndgrigorian reviewed Aug 22, 2025
View reviewed changes
ndgrigorian
ndgrigorian reviewed Aug 24, 2025
View reviewed changes
ndgrigorian
ndgrigorian reviewed Aug 24, 2025
View reviewed changes
@abagusetty
Copy link

Just wanted to tag, it could fix: #2498

Base automatically changed from impl_lu_factor to master August 28, 2025 08:46
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 72.19% (+0.006%) from 72.184%
when pulling 46deac3 on impl_lu_factor_batch
into 6eb6f6f on master.

@vlad-perevezentsev vlad-perevezentsev merged commit d975818 into master Aug 29, 2025
96 of 106 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the impl_lu_factor_batch branch August 29, 2025 10:56
github-actions bot added a commit that referenced this pull request Aug 29, 2025
@github-actions
Implement dpnp.linalg.lu_factor batch inputs (#2565)
49f621c 
This PR suggests extending `dpnp.linalg.lu_factor()` #2557 for batch
arrays

In addition, this PR includes:
An updated implementation of getrf_batch to support non-square
matrices d975818
@antonwolfy antonwolfy added this to the 0.19.0 release milestone Aug 29, 2025
vlad-perevezentsev added a commit that referenced this pull request Sep 4, 2025
@vlad-perevezentsev
Implement dpnp.linalg.lu_factor batch inputs (#2565)
d3181e6 
This PR suggests extending `dpnp.linalg.lu_factor()` #2557 for batch
arrays

In addition, this PR includes:
An updated implementation of getrf_batch to support non-square
matrices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vtavana vtavana Awaiting requested review from vtavana

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels

None yet

Projects

None yet

Milestone

0.19.0 release

Development

Successfully merging this pull request may close these issues.

5 participants

@vlad-perevezentsev @abagusetty @coveralls @ndgrigorian @antonwolfy