Skip to content

Conversation

vlad-perevezentsev
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev commented Sep 1, 2025

This PR suggests minor upgrades for dpnp.linalg.lu_factor() including docstring fixes, clearer warnings, improved dependency handling, adding a function to documentation generation and updating tests to use dpnp.allclose instead of assert_allclose

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

Copy link
Contributor

github-actions bot commented Sep 1, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Contributor

github-actions bot commented Sep 1, 2025

Array API standard conformance tests for dpnp=0.19.0dev3=py313h509198e_23 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Sep 1, 2025

Coverage Status

coverage: 72.19% (+0.001%) from 72.189%
when pulling 4e19341 on fix_lu_factor
into 3c8ac08 on master.

Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vlad-perevezentsev vlad-perevezentsev merged commit 5584348 into master Sep 2, 2025
75 of 84 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the fix_lu_factor branch September 2, 2025 08:48
github-actions bot added a commit that referenced this pull request Sep 2, 2025
This PR suggests minor upgrades for `dpnp.linalg.lu_factor()` including
docstring fixes, clearer warnings, improved dependency handling, adding
a function to documentation generation and updating tests to use
`dpnp.allclose` instead of `assert_allclose` 5584348
vlad-perevezentsev added a commit that referenced this pull request Sep 4, 2025
This PR suggests minor upgrades for `dpnp.linalg.lu_factor()` including
docstring fixes, clearer warnings, improved dependency handling, adding
a function to documentation generation and updating tests to use
`dpnp.allclose` instead of `assert_allclose`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants