Skip to content

Add missing includes to files in ufunc and VM extensions #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 3, 2025
Merged

Add missing includes to files in ufunc and VM extensions #2571

merged 6 commits into from
Sep 3, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Sep 2, 2025 •
edited
Loading

The PR adds missing includes to source files in ufunc and VM pybind11 extensions.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Sep 2, 2025
@antonwolfy antonwolfy self-assigned this Sep 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.19.0dev3=py313h509198e_22 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

coveralls commented Sep 2, 2025 •
edited
Loading

Coverage Status

coverage: 72.19%. remained the same
when pulling 66a5b87 on add-missing-includes
into 9d1228c on master.

vlad-perevezentsev
vlad-perevezentsev approved these changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy !

@antonwolfy antonwolfy merged commit f2b7d76 into master Sep 3, 2025
68 of 71 checks passed
@antonwolfy antonwolfy deleted the add-missing-includes branch September 3, 2025 17:22
github-actions bot added a commit that referenced this pull request Sep 3, 2025
@github-actions
Add missing includes to files in ufunc and VM extensions (#2571)
32d2676 
The PR adds missing includes to source files in ufunc and VM pybind11
extensions. f2b7d76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vtavana vtavana Awaiting requested review from vtavana

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

0.19.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@antonwolfy @coveralls @vlad-perevezentsev