Skip to content

Revert gh-2579 with skipping batched cholesky tests on win ARL and MTL #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 29, 2025
Merged

Revert gh-2579 with skipping batched cholesky tests on win ARL and MTL #2582

merged 5 commits into from
Sep 29, 2025

Conversation

vlad-perevezentsev
Copy link
Contributor

This PR suggest removing the temporary slip batched Cholesky tests that were added in #2579.
With driver update on CI ARL machines the issue was solved.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Sep 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.19.0dev6=py313h509198e_12 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Sep 16, 2025 •
edited
Loading

Coverage Status

Changes unknown
when pulling 6829b9c on unskip_cholesky_arl
into ** on master**.

antonwolfy
antonwolfy approved these changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are passing now. Thank you @vlad-perevezentsev

@antonwolfy antonwolfy merged commit 93ccb91 into master Sep 29, 2025
95 of 98 checks passed
@antonwolfy antonwolfy deleted the unskip_cholesky_arl branch September 29, 2025 17:15
github-actions bot added a commit that referenced this pull request Sep 29, 2025
@github-actions
Revert gh-2579 with skipping batched cholesky tests on win ARL and MTL (
90118e1 
#2582)

This PR suggest removing the temporary slip batched Cholesky tests that
were added in #2579.
With driver update on CI ARL machines the issue was solved. 93ccb91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vtavana vtavana Awaiting requested review from vtavana

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlad-perevezentsev @coveralls @antonwolfy