Skip to content

Follow up the fix implemented in gh-2530 to fix dpnp.unique with axis=0 and 1d input #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 23, 2025
Merged

Follow up the fix implemented in gh-2530 to fix dpnp.unique with axis=0 and 1d input #2587

merged 4 commits into from
Sep 23, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Sep 22, 2025 •
edited
Loading

The PR improves the fix implemented in dpnp.unique for axis=0 and 1d input.
Also it adds an explicit validation in case of floating axis passed.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Sep 22, 2025
@antonwolfy antonwolfy self-assigned this Sep 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.19.0dev4=py313h509198e_10 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.779% (-0.001%) from 71.78%
when pulling b33aa5e on follow-up-gh-2530
into b27a7ca on master.

vlad-perevezentsev
vlad-perevezentsev approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 12c324b into master Sep 23, 2025
96 of 98 checks passed
@antonwolfy antonwolfy deleted the follow-up-gh-2530 branch September 23, 2025 09:53
github-actions bot added a commit that referenced this pull request Sep 23, 2025
@github-actions
Follow up the fix implemented in gh-2530 to fix dpnp.unique with ax…
0eac767 
…is=0 and 1d input (#2587)

The PR improves the fix implemented in `dpnp.unique` for axis=0 and 1d
input.
Also it adds an explicit validation in case of floating axis passed. 12c324b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vtavana vtavana Awaiting requested review from vtavana

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
0.19.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @coveralls @vlad-perevezentsev