Added implementation of dpnp.special.erfc
#2588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ader for the extensions
… init_dispatch_table() from common utils
…ch_table() from common utils
…spatch_table() from common utils
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.19.0dev6=py313h509198e_22 ran successfully. |
antonwolfy
changed the title
dpnp.erfc through pybind11 extensiondpnp.special.erfc
antonwolfy
requested review from
AlexanderKalistratov,
ndgrigorian,
vlad-perevezentsev and
vtavana
as code owners
Collaborator
vlad-perevezentsev
approved these changes
Sep 25, 2025
Contributor
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy for erfc implementation and the helpful code simplifications by introducing shared init dispatch templates
github-actions bot
added a commit
that referenced
this pull request
Sep 25, 2025
The PR add the implementation of `dpnp.special.erfc` function, including tests coverage. Also it reworks the previous implementation of erf function to reduce future code duplication. because most of erf-like function has the same types supported and similar signature. 8906b0e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR add the implementation of
dpnp.special.erfcfunction, including tests coverage.Also it reworks the previous implementation of erf function to reduce future code duplication. because most of erf-like function has the same types supported and similar signature.