Skip to content

Avoid generating singular matrices in TestLuFactor/TestLuFactorBatched #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 30, 2025
Merged

Avoid generating singular matrices in TestLuFactor/TestLuFactorBatched #2599

merged 7 commits into from
Sep 30, 2025

Conversation

vlad-perevezentsev
Copy link
Contributor

This PR suggests adding _make_nonsingular_np and ``_make_nonsingular_nd_np functions to TestLuFactor and `TestLuFactorBatched` to ensure the generation of non-singular matrices and avoid warnings in test log

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Sep 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 29, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 29, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.19.0dev6=py313h509198e_16 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Sep 29, 2025 •
edited
Loading

Coverage Status

coverage: 71.998%. remained the same
when pulling 6b6d6b5 on fix_warnings_lu_factor
into 9e9c446 on master.

antonwolfy
antonwolfy reviewed Sep 30, 2025
View reviewed changes
antonwolfy
antonwolfy approved these changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warnings are gone. Thank you @vlad-perevezentsev

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Sep 30, 2025
@antonwolfy antonwolfy merged commit 6711bbd into master Sep 30, 2025
71 of 72 checks passed
@antonwolfy antonwolfy deleted the fix_warnings_lu_factor branch September 30, 2025 14:33
github-actions bot added a commit that referenced this pull request Sep 30, 2025
@github-actions
Avoid generating singular matrices in TestLuFactor/TestLuFactorBatched (
21a095d 
#2599)

This PR suggests adding `_make_nonsingular_np` and
``_make_nonsingular_nd_np functions to `TestLuFactor` and
`TestLuFactorBatched` to ensure the generation of non-singular matrices
and avoid warnings in test log 6711bbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
0.19.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@vlad-perevezentsev @coveralls @antonwolfy