Implement dpnp.linalg.lu_solve() batch inputs
#2619
Conversation
vlad-perevezentsev
requested review from
antonwolfy and
ndgrigorian
as code owners
|
Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_24 ran successfully. |
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2619/index.html |
| throw py::value_error("The right-hand sides array " | ||
| "must be F-contiguous"); | ||
| } | ||
| if (!is_ipiv_array_c_contig && !is_ipiv_array_f_contig) { |
There was a problem hiding this comment.
If it must be both C- and F-contiguous
| if (!is_ipiv_array_c_contig && !is_ipiv_array_f_contig) { | |
| if (!is_ipiv_array_c_contig || !is_ipiv_array_f_contig) { |
There was a problem hiding this comment.
We should only get an error if the array is neither C-contig or F-contig
Using || will result in an error if either flag is false
There was a problem hiding this comment.
But in getrs implementation used &&, it must be aligned somewhere.
There was a problem hiding this comment.
&& is used in getrs and in getrs_batch
There was a problem hiding this comment.
no, in getrs:
if (!is_ipiv_array_c_contig || !is_ipiv_array_f_contig) {
throw py::value_error("The array of pivot indices "
"must be contiguous");
}There was a problem hiding this comment.
My bad
Fixed it in getrs
Thank you!
3 participants
This PR suggests extending
dpnp.linalg.lu_solve()#2575 for batch arrays and adding new lapackgetrs_batchextension