Skip to content

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Apr 17, 2025

migrate from setup.py to pyproject.toml

@vtavana vtavana self-assigned this Apr 17, 2025
@vtavana vtavana force-pushed the pyproject branch 2 times, most recently from dfbf8ae to 1b8184d Compare April 17, 2025 17:06
@vtavana vtavana marked this pull request as ready for review April 18, 2025 00:03
@Copilot Copilot AI review requested due to automatic review settings April 18, 2025 00:03
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the package configuration from setup.py to pyproject.toml, streamlining build declarations and version management. Key changes include:

  • Removal of legacy setup.py logic and introduction of pyproject.toml for modern build configuration and metadata.
  • Extraction of the package’s version into mkl/_version.py and updating init.py accordingly.
  • Updates in CI and conda recipe files to align with the new build process and dependency requirements.

Reviewed Changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
setup.py Removed legacy build logic and updated extension definitions to work with pyproject.toml.
pyproject.toml Introduced new build configuration and project metadata.
mkl/_version.py Added version file to centrally manage the package version.
mkl/init.py Updated version import to use the new mkl/_version module.
conda-recipe/meta.yaml Adjusted dependency specifications and description to reference OneMKL.
CHANGELOG.md Updated changelog to reflect new versioning and build process changes.
.github/workflows/conda-package.yml Updated CI configuration for conda package building.
.github/workflows/build-with-clang.yml Updated required setuptools version to be compatible with the new build process.
.github/dependabot.yml Minor update to dependabot configuration.
Files not reviewed (2)
  • conda-recipe/bld.bat: Language not supported
  • conda-recipe/build.sh: Language not supported

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vtavana vtavana merged commit 17d0987 into master Apr 23, 2025
20 checks passed
@vtavana vtavana deleted the pyproject branch April 23, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants