Skip to content

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Apr 23, 2025

No description provided.

@vtavana vtavana self-assigned this Apr 23, 2025
@vtavana vtavana marked this pull request as ready for review April 23, 2025 22:52
@Copilot Copilot AI review requested due to automatic review settings April 23, 2025 22:52
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds pre-commit hooks and a corresponding GitHub Action workflow to improve code quality and enforce formatting rules across the repository. Other changes include minor formatting adjustments (such as standardizing string quotes) throughout the codebase.

  • Updated setup.py and pyproject.toml for minor formatting consistency.
  • Reformatted test and C extension files for clarity.
  • Introduced .pre-commit-config.yaml and .github/workflows/pre-commit.yml for automated pre-commit checks.

Reviewed Changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
setup.py Added missing comma in the libraries list and formatting cleanup
pyproject.toml Removed superfluous blank line before the build-system section
mkl/tests/test_mkl_service.py Standardized string literals and added a pylint disable comment
mkl/_mklinitmodule.c Reformatted multi-line macro definitions for improved readability
mkl/init.py Reformatting class comments and minor stylistic adjustments
examples/example.py Changed single quotes to double quotes; note a typo in printed message
.pre-commit-config.yaml New pre-commit configuration file with a variety of hooks
.github/workflows/pre-commit.yml New GitHub Action to run the pre-commit hooks on push and pull requests
Files not reviewed (2)
  • .flake8: Language not supported
  • .git-blame-ignore-revs: Language not supported

Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vtavana

@vtavana vtavana merged commit b8aa01f into master Apr 25, 2025
25 checks passed
@vtavana vtavana deleted the precommit-hooks branch April 25, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants