-
Notifications
You must be signed in to change notification settings - Fork 38
Add pre-commit hooks #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds pre-commit hooks and a corresponding GitHub Action workflow to improve code quality and enforce formatting rules across the repository. Other changes include minor formatting adjustments (such as standardizing string quotes) throughout the codebase.
- Updated setup.py and pyproject.toml for minor formatting consistency.
- Reformatted test and C extension files for clarity.
- Introduced .pre-commit-config.yaml and .github/workflows/pre-commit.yml for automated pre-commit checks.
Reviewed Changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
setup.py | Added missing comma in the libraries list and formatting cleanup |
pyproject.toml | Removed superfluous blank line before the build-system section |
mkl/tests/test_mkl_service.py | Standardized string literals and added a pylint disable comment |
mkl/_mklinitmodule.c | Reformatted multi-line macro definitions for improved readability |
mkl/init.py | Reformatting class comments and minor stylistic adjustments |
examples/example.py | Changed single quotes to double quotes; note a typo in printed message |
.pre-commit-config.yaml | New pre-commit configuration file with a variety of hooks |
.github/workflows/pre-commit.yml | New GitHub Action to run the pre-commit hooks on push and pull requests |
Files not reviewed (2)
- .flake8: Language not supported
- .git-blame-ignore-revs: Language not supported
0a7b9f8
to
4085485
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @vtavana
4085485
to
f07b915
Compare
No description provided.