Skip to content

Conversation

ndgrigorian
Copy link
Collaborator

Partially revert #229, specifically 0098901, which vendored functions from SciPy rather than wrapping them, resurfacing the circular dependency issue

For me locally, this resolves the problem

@ndgrigorian ndgrigorian force-pushed the revert-gh-229-scipy-vendoring branch from 319b833 to 04afc91 Compare October 8, 2025 19:21
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me locally also

@ekomarova
Copy link
Collaborator

I'll check the package with this change

Copy link
Collaborator

@ekomarova ekomarova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it works

ndgrigorian added a commit that referenced this pull request Oct 9, 2025
@ndgrigorian ndgrigorian force-pushed the revert-gh-229-scipy-vendoring branch from 0401da2 to 24b5efa Compare October 9, 2025 15:22
@ndgrigorian ndgrigorian merged commit 3121b76 into master Oct 9, 2025
85 checks passed
@ndgrigorian ndgrigorian deleted the revert-gh-229-scipy-vendoring branch October 9, 2025 16:00
@ndgrigorian ndgrigorian restored the revert-gh-229-scipy-vendoring branch October 9, 2025 16:00
@ndgrigorian ndgrigorian deleted the revert-gh-229-scipy-vendoring branch October 9, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants