Fix test_windows in CI #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndgrigorian
force-pushed
the
fix-test-windows
branch
4 times, most recently
from
e21c430 to
9709fc1
Compare
ndgrigorian
force-pushed
the
fix-test-windows
branch
from
9709fc1 to
0a092df
Compare
ndgrigorian
requested review from
antonwolfy,
ekomarova and
xaleryb
as code owners
|
CI fixed with the work-around, manually adding intel-openmp, which is somehow missed as a dependency when mkl_umath is installed with exact package and build versions |
|
Can we wait for conda-forge/intel_repack-feedstock#95 to be merged? If that doesn't solve the problem, then we will merge this PR |
|
Weird, I'm still seeing this problem. Okay, let's merge this to address the issue but we'll need to figure out why this is happening 🤔 |
ekomarova
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the test_windows step in conda-package.yml by manually installing
intel-openmpinto the environment, which is missed as a dependency inexplicably when themkl_umathpackage and build versions are specified, or it is installed from a local channel in general.Also slips in a change properly defining the
VER_SCRIPT1andVER_SCRIPT2environment variables in the conda-package workflow