feat: remove char block sections array#3105
Merged
Conversation
Member
dordsor21
commented
Feb 9, 2025
dordsor21
commented
- replace with "forced" memory access order to eliminate race conditions between sections and blocks arrays
SirYwell
reviewed
Feb 10, 2025
...t-core/src/main/java/com/fastasyncworldedit/core/queue/implementation/blocks/CharBlocks.java
Outdated
Show resolved
Hide resolved
SirYwell
reviewed
Feb 10, 2025
...t-core/src/main/java/com/fastasyncworldedit/core/queue/implementation/blocks/CharBlocks.java
Outdated
Show resolved
Hide resolved
...t-core/src/main/java/com/fastasyncworldedit/core/queue/implementation/blocks/CharBlocks.java
Outdated
Show resolved
Hide resolved
...t-core/src/main/java/com/fastasyncworldedit/core/queue/implementation/blocks/CharBlocks.java
Outdated
Show resolved
Hide resolved
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
dordsor21
force-pushed
the
feat/remove-charblock-sections-arr
branch
from
35f24eb to
54b98fe
Compare
SirYwell
approved these changes
Mar 8, 2025
NotMyFault
approved these changes
Mar 23, 2025
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
- replace with "forced" memory access order to eliminate race conditions between sections and blocks arrays
dordsor21
force-pushed
the
feat/remove-charblock-sections-arr
branch
from
54b98fe to
3d197c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.