feat: extend use of "FaweThread" to include main blocking executor#3254
Merged
NotMyFault merged 2 commits intomainfrom Jul 30, 2025
Merged
feat: extend use of "FaweThread" to include main blocking executor#3254NotMyFault merged 2 commits intomainfrom
NotMyFault merged 2 commits intomainfrom
Conversation
dordsor21
force-pushed
the
feat/extend-fawe-threads
branch
from
058b5f5 to
b5e7a6e
Compare
SirYwell
reviewed
Jul 29, 2025
worldedit-core/src/main/java/com/fastasyncworldedit/core/util/task/FaweBasicThreadFactory.java
Outdated
Show resolved
Hide resolved
| protected FaweThread(final ForkJoinPool pool) { | ||
| super(null, pool, true); | ||
| } | ||
| public interface FaweThread { |
Member
There was a problem hiding this comment.
While this is already all internal, would it make sense to seal the hierarchy and make the subclasses final?
dordsor21
force-pushed
the
feat/extend-fawe-threads
branch
from
b5e7a6e to
0cb082f
Compare
SirYwell
approved these changes
Jul 30, 2025
NotMyFault
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.