feat: add BlockVector3 radius square to Ellipsoid to reduce rounding#3269
Merged
NotMyFault merged 1 commit intomainfrom Aug 8, 2025
Merged
feat: add BlockVector3 radius square to Ellipsoid to reduce rounding#3269NotMyFault merged 1 commit intomainfrom
NotMyFault merged 1 commit intomainfrom
Conversation
SirYwell
approved these changes
Aug 8, 2025
Member
SirYwell
left a comment
SirYwell
left a comment
There was a problem hiding this comment.
Looks fine, do you have any numbers for comparison or a scenario where the change is noticeable?
Member
Author
Not really, just noticed that the Ellipsoid contain was taking somewhat longer than I would have expected, and this is the only reasonable optimisation |
NotMyFault
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.