Properly handle incomplete selection in RegionCommands#3388
Merged
PierreSchwang merged 1 commit intomainfrom Dec 12, 2025
Merged
Properly handle incomplete selection in RegionCommands#3388PierreSchwang merged 1 commit intomainfrom
PierreSchwang merged 1 commit intomainfrom
Conversation
PierreSchwang
approved these changes
Nov 30, 2025
dordsor21
approved these changes
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #3387
Description
There are 2 problems here:
IncompleteRegionException. I didn't find any reason for this binding to exist, so I think removing it make the most sense.Submitter Checklist
@since TODO.