Execute chunk loading operations outside the main thread#4522
Execute chunk loading operations outside the main thread#4522dordsor21 merged 7 commits intoIntellectualSites:mainfrom
Conversation
PierreSchwang
left a comment
There was a problem hiding this comment.
Can't see any obvious errors, and seems to be working ingame. My only nitpicks currently are
- Use a Logger instead of
Throwable#printStackTrace - I think we are using javax Annotations, instead of Jetbrains Annotations (not 100% sure on that though - another review is required either way)
|
I would address the above things Pierre raised before merge - we should avoid merging code "smells" |
|
To be honest, It's hard to get any information about correct code-styling. I can easly find a file with both - NotNull and NonNull annotations. But I'm more than happy to modify my PR to use javax if that's the correct one. |
|
Yeah it should switch to javax. Any issues already in the code can be fixed as and when but I'm opposed to introducing new "problems" if we don't need to |
… into feature/thread-friendly-command
|
Now, everything should be fine. |
There was a problem hiding this comment.
Why are we changing away from the message formatting used by log4j?
LOGGER.error("Failed to register command {}", command.getCanonicalName(), e);
Overview
Description
Now, main command will wait with further execution until plot center location is asynchronously obtained. This will free the main thread while reaching plot in unloaded chunk
Submitter Checklist
@since TODO.