1.21.4

[PierreSchwang]

Overview

Not tested yet, checked IDs against minecraft wiki and seems to work out.

### Submitter Checklist
- [x] Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.
- [x] Ensure that the pull request title represents the desired changelog entry.
- [x] New public fields and methods are annotated with `@since TODO`.
- [x] I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

[dordsor21]

Do all these new classes/fields exist in 1.19.4? We still technically target it for support in P2 I believe?

[PierreSchwang]

Do all these new classes/fields exist in 1.19.4? We still technically target it for support in P2 I believe?

Seems to be the case

• https://helpch.at/docs/1.19.4/org/bukkit/entity/minecart/ExplosiveMinecart.html
• https://helpch.at/docs/1.19.4/org/bukkit/entity/EnderCrystal.html
• https://helpch.at/docs/1.19.4/org/bukkit/entity/Item.html
• https://helpch.at/docs/1.19.4/org/bukkit/NamespacedKey.html#minecraft(java.lang.String)
• https://helpch.at/docs/1.19.4/org/bukkit/entity/EntityType.html#getKey()
• https://helpch.at/docs/1.19.4/org/bukkit/entity/FishHook.html
• https://helpch.at/docs/1.19.4/org/bukkit/entity/Firework.html

[PierreSchwang]

I think I should look at the PR again, as there are seemingly string constants for entity types in the code, which obviously weren't caught by the newer paper api

[PierreSchwang]

I'm not gonna touch the ReplicatingEntityWrapper (required for plot clear as it seems?). That would need a whole refactor for maaany things (and potentially a migration to just storing the entities as NBT - but that's something that has to be discussed).

[dordsor21]

I'm not gonna touch the ReplicatingEntityWrapper (required for plot clear as it seems?). That would need a whole refactor for maaany things (and potentially a migration to just storing the entities as NBT - but that's something that has to be discussed).

Does it need a refactor though? What needs refactoring?

[PierreSchwang]

I'm not gonna touch the ReplicatingEntityWrapper (required for plot clear as it seems?). That would need a whole refactor for maaany things (and potentially a migration to just storing the entities as NBT - but that's something that has to be discussed).

Does it need a refactor though? What needs refactoring?

Well, without looking further, the first things I noticed:

• many entity types are not supported / added
• only BOAT is currently added (not the individual ones, like OAK_BOAT etc), setting the dataByte to the ordinal value of getWoodType of TreeVariant (which does not support all supported wood types)
• Chest-Boats are not supported at all (no inventory, no dataByte)
• Rafts are missing

I guess I could add the named ones, but it would be really great to get to java 21 to use type pattern matching in the switch-cases (though, blocked by SpigotMC atm)

[dordsor21]

I'm not gonna touch the ReplicatingEntityWrapper (required for plot clear as it seems?). That would need a whole refactor for maaany things (and potentially a migration to just storing the entities as NBT - but that's something that has to be discussed).

Does it need a refactor though? What needs refactoring?

Well, without looking further, the first things I noticed:

• many entity types are not supported / added
• only BOAT is currently added (not the individual ones, like OAK_BOAT etc), setting the dataByte to the ordinal value of getWoodType of TreeVariant (which does not support all supported wood types)
• Chest-Boats are not supported at all (no inventory, no dataByte)
• Rafts are missing

I guess I could add the named ones, but it would be really great to get to java 21 to use type pattern matching in the switch-cases (though, blocked by SpigotMC atm)

Perhaps just minimal work for 1.21.4 and we can revisit this later? I don't see much issue with using strings - multi-version support is tricky otherwise.

[dordsor21]

Looks good enough for now to me