renewed fix: update error message of /p remove <player> if player does not need to be removed#4592
Merged
dordsor21 merged 1 commit intoIntellectualSites:mainfrom Feb 22, 2025
TheJonstone:feature/v7/remove-message-rework
Merged
renewed fix: update error message of /p remove <player> if player does not need to be removed#4592dordsor21 merged 1 commit intoIntellectualSites:mainfrom TheJonstone:feature/v7/remove-message-rework
/p remove <player> if player does not need to be removed#4592dordsor21 merged 1 commit intoIntellectualSites:mainfrom
TheJonstone:feature/v7/remove-message-rework
Conversation
Member
|
How can it be that the old PR change is not included? The branch |
Member
|
The earlier merged change of Xaver was removed by mistakes with the merge-conflict resolving of commit 6efd581. GitHub doesn't show all changes of I have looked at all of
|
dordsor21
approved these changes
Feb 15, 2025
PierreSchwang
approved these changes
Feb 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request update an error message that was already included in pull request #3734 in PlotSquared v6.
Unfortunately, the change from back then was not adopted in v7, hence the request to reintegrate this change now.
Notice PR #3734 : The placeholder
“member.player_not_removed”already exists.In v7, only the reference to this placeholder is missing in the Remove.java command.
Description
Update/Changes the message if you try to remove a player from a plot, which is not added, trusted or denied from the plot to make it more clear, why the command failed.