fix: plot entry trigger on teleport#4593
Merged
dordsor21 merged 2 commits intoIntellectualSites:mainfrom Mar 5, 2025
Merged
Conversation
github-actions
bot
added
Bugfix
dordsor21
approved these changes
Feb 15, 2025
Member
|
Yes, good point. Thank you. |
Member
|
Does this also handle merged plots? |
Member
Probably not, should be a |
dordsor21
requested changes
Feb 22, 2025
Bukkit/src/main/java/com/plotsquared/bukkit/listener/PlayerEventListener.java
Show resolved
Hide resolved
2 tasks
Contributor
Author
|
I've tested my code, by me it works totally fine. As baseplot references the main plot of a merge, this would also work, but plot in this case is the whole merge. 2025-02-25_15-11-02.1.mp4 |
SirYwell
approved these changes
Feb 25, 2025
dordsor21
approved these changes
Feb 28, 2025
Member
dordsor21
left a comment
dordsor21
left a comment
There was a problem hiding this comment.
the PlotArea#getPlot calls getBasePlot itself 👍
dordsor21
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The teleportevent will not longer trigger the plot-entry method in PlotListener, if currentplot = lastplot.
Description
This will change the way the entry is handled on teleport. If the current plot is the last plot, the teleportevent will not longer trigger the plot-entry method in PlotListener.