fix: attempt to address unnecessary flight status changes#4744
Merged
NotMyFault merged 2 commits intomainfrom Dec 20, 2025
Merged
fix: attempt to address unnecessary flight status changes#4744NotMyFault merged 2 commits intomainfrom
NotMyFault merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses unnecessary flight status changes when players exit plots by modifying the plotExit method to consider the destination plot's flight settings before disabling flight. The changes prevent flight from being unnecessarily disabled when moving between plots that both allow flight.
- Added
nextPlotandnextAreaparameters to theplotExitmethod to provide context about the destination - Updated flight logic to check destination flight settings before disabling flight
- Updated all callers of
plotExitto pass the new parameters
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Plot.java | Updated plotExit calls to pass additional parameters for destination context |
| PlotListener.java | Modified plotExit method signature and added logic to check destination flight settings |
| PlayerEventListener.java | Updated plotExit calls to include destination plot/area information |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Core/src/main/java/com/plotsquared/core/listener/PlotListener.java
Outdated
Show resolved
Hide resolved
NotMyFault
approved these changes
Aug 26, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
75b2665 to
510150a
Compare
PierreSchwang
approved these changes
Dec 20, 2025
pull bot
pushed a commit
to Craftstuebchen/PlotSquared
that referenced
this pull request
Dec 21, 2025
…alSites#4744) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.