Skip to content

Adjust web side for new tooling changes (Key -> Keys and OrderOnPage) #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Dec 14, 2024
Merged

Adjust web side for new tooling changes (Key -> Keys and OrderOnPage) #674

merged 20 commits into from
Dec 14, 2024

Conversation

@Joshua-Lester3
Copy link
Collaborator

@Joshua-Lester3 Joshua-Lester3 commented Dec 4, 2024 •
edited
Loading

Description

Adding support for new Tooling side update: adjusting from SiteMapping.Key to Keys as well as sorting by OrderOnPage since the new Tooling update changes how sitemap.json is ordered.

Ensure that your pull request has followed all the steps below:

  • Code compilation
  • Created tests which fail without the change (if possible)
  • All tests passing

@Joshua-Lester3 Joshua-Lester3 force-pushed the BMichaelis/UpdateSitemaps branch from 7b2c3ec to eefdf2d Compare December 4, 2024 00:51
@Joshua-Lester3 Joshua-Lester3 force-pushed the BMichaelis/UpdateSitemaps branch from eefdf2d to 3a9a1ca Compare December 4, 2024 00:58
ascott18
ascott18 reviewed Dec 5, 2024
View reviewed changes
@Joshua-Lester3
Revert "Add helper method + more key => keys fixes"
cafc5aa 
This reverts commit 1fb2ffb.

Revert "Change stringify implementation"

This reverts commit 98f4423.

Redo buried changes for key => keys
@Joshua-Lester3
Redo design and refactor
52e183a
@Joshua-Lester3 Joshua-Lester3 merged commit 67a6148 into main Dec 14, 2024
7 checks passed
@Joshua-Lester3 Joshua-Lester3 deleted the BMichaelis/UpdateSitemaps branch December 14, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ascott18 ascott18 ascott18 left review comments

@BenjaminMichaelis BenjaminMichaelis BenjaminMichaelis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Joshua-Lester3 @ascott18 @BenjaminMichaelis