Skip to content

feat: Remember Sidebar state #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

feat: Remember Sidebar state #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion EssentialCSharp.Web/Views/Shared/_Layout.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
<header class="header-background">
<div class="banner d-flex justify-content-between">
<div class="d-flex align-items-center menu-position">
<button class="menu-btn has-tooltip" v-on:click="sidebarShown = !sidebarShown">
<button class="menu-btn has-tooltip" v-on:click="toggleSidebar">
<i class="fa fa-bars fa-lg icon-light"></i>
<span class="tooltip-text sidebar-tooltip-text">
<b>Ctrl + M</b>
Expand Down
34 changes: 23 additions & 11 deletions EssentialCSharp.Web/wwwroot/js/site.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,16 +179,21 @@ const app = createApp({
}

if (e.code == "KeyM" && e.ctrlKey) {
sidebarShown.value = !sidebarShown.value;
toggleSidebar();
}
});

const sidebarShown = ref(false);
const sidebarShown = ref(localStorage.getItem('sidebarShown'));

const smallScreen = computed(() => {
return (windowWidth.value || 0) < smallScreenSize;
});

function toggleSidebar() {
sidebarShown.value = !sidebarShown.value;
localStorage.setItem('sidebarShown', sidebarShown.value);
}

/** @type {import("vue").Ref<"toc" | "search">} */
const sidebarTab = ref("toc");

Expand All @@ -207,13 +212,16 @@ const app = createApp({
watch(windowWidth, (newWidth, oldWidth) => {
//+ 50 so that the side bar diappears before the css media class changes the sidebar to take
// over the full screen
if (newWidth < smallScreenSize) {
sidebarShown.value = false;
}
// when making screen bigger reveal sidebar
else {
if (!sidebarShown.value) {
sidebarShown.value = true;
// If a setting is set in storage already, follow that
if (sidebarShown.value === null) {
if (newWidth < smallScreenSize) {
sidebarShown.value = false;
}
// when making screen bigger reveal sidebar
else {
if (!sidebarShown.value) {
sidebarShown.value = true;
}
}
}
});
Expand All @@ -230,8 +238,11 @@ const app = createApp({
});

onMounted(() => {
if (windowWidth.value > smallScreenSize) {
sidebarShown.value = true;
// If a setting is set in storage already, follow that
if (sidebarShown.value === null) {
if (windowWidth.value > smallScreenSize) {
sidebarShown.value = true;
}
}

// Scroll the current selected page in the TOC into view of the TOC.
Expand Down Expand Up @@ -304,6 +315,7 @@ const app = createApp({

sidebarShown,
sidebarTab,
toggleSidebar,

smallScreen,

Expand Down