Skip to content

Fix referral ID missing in hyperlinks for external login users #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2025
Merged

Fix referral ID missing in hyperlinks for external login users #749

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e3319c2
Initial plan
Copilot Jul 11, 2025
ab31970
Initial analysis of referral ID issue with external login
Copilot Jul 11, 2025
5f3d84a
Fix referral ID missing in external login flows
Copilot Jul 11, 2025
a56a322
Delete dotnet-install.sh
BenjaminMichaelis Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions EssentialCSharp.Web/Areas/Identity/Pages/Account/ExternalLogin.cshtml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ public async Task<IActionResult> OnGetCallbackAsync(string? returnUrl = null, st
if (user != null)
{
await referralService.EnsureReferralIdAsync(user);
Copy link

Copilot AI Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The logic to ensure referral ID and then refresh or sign in the user is duplicated in both existing and new user flows. Consider extracting this into a shared helper method to reduce duplication and improve readability.

Copilot uses AI. Check for mistakes.
// Refresh sign-in to pick up the newly added referral ID claim
await signInManager.RefreshSignInAsync(user);
}
return LocalRedirect(returnUrl);
}
Expand Down Expand Up @@ -189,6 +191,8 @@ await emailSender.SendEmailAsync(Input.Email, "Confirm your email",
return RedirectToPage("./RegisterConfirmation", new { Email = Input.Email });
}

// Ensure referral ID is set for the new user before signing in
await referralService.EnsureReferralIdAsync(user);
await signInManager.SignInAsync(user, isPersistent: false, info.LoginProvider);
return LocalRedirect(returnUrl);
}
Expand Down