feat: Update tooling version and improve sitemap modified date #785
+24
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the tooling package version and enhances sitemap generation to use actual last modified dates from site mappings instead of a generic timestamp. The change improves SEO by providing more accurate modification dates to search engines.
- Updates tooling package version from 1.1.1.5540 to 1.1.1.17995
- Modifies sitemap generation to use
siteMapping.LastModifiedwhen available, falling back tonewDateTime - Adds comprehensive test coverage for the new last modified date functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| EssentialCSharp.Web/Helpers/SitemapXmlHelpers.cs | Updates sitemap node creation to use site mapping's LastModified property |
| EssentialCSharp.Web.Tests/SitemapXmlHelpersTests.cs | Replaces file creation test with focused test for LastModified date usage |
| Directory.Packages.props | Updates tooling package version to latest release |
BenjaminMichaelis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the tooling package version to 1.1.1.17995 and enhance sitemap generation to utilize the last modified date from site mappings.
Contributes to #754