fix: TryAddSegment when a segments prepends a existing Segment #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was failing, as the newSegment was extended by the old one, but the Memory still references the original segment!
There was a problem hiding this comment.
Pull request overview
Fixes RawMemory.TryAddSegment so that when a new segment is prepended (and therefore extended to include) an existing segment, the Segments list is updated to reference the combined segment (closing #15).
Changes:
- Replaces the previous
Any(...)-based extension check with an indexed loop so the list entry can be updated whennewSegmentabsorbs an existing segment. - Keeps the existing behavior of rejecting overlaps and sorting only when a truly new segment is added.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
21
to
24
| if (Segments.Any((s) => s.Overlaps(newSegment))) | ||
| { | ||
| return false; | ||
| } |
Member
There was a problem hiding this comment.
Let's simplify the overall logic, and reduce to a single loop, move this check into your for loop please.
Member
|
Hi @belucha, thanks for your contribution! May I ask how you stumbled upon this bug, being the first to face this issue? |
Author
|
I merged several hex files with e.g. separate version records created separately, then merging somehow failed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15
This was failing, as the newSegment was extended by the old one, but the Memory still references the original segment!