Open
Conversation
wannesvanloock
approved these changes
Mar 5, 2018
wannesvanloock
left a comment
wannesvanloock
left a comment
There was a problem hiding this comment.
I like it. Looks like a clean way to me 👍
|
|
||
| install(DIRECTORY include/${PROJECT_NAME}/ | ||
| DESTINATION ${CATKIN_PACKAGE_INCLUDE_DESTINATION} | ||
| PATTERN ".svn" EXCLUDE |
Author
There was a problem hiding this comment.
Apparently. 😋 I got it from another CMakeLists.txt I could probably remove it.
| std::string goal_reached_srv_ = "goal_reached"; | ||
| std::string set_plan_srv_ = "set_plan"; | ||
| std::string initialize_srv_ = "initialize"; | ||
| std::string compute_velocity_srv_ = "compute_velocity"; |
omg_local_planner/package.xml
Outdated
| <version>0.0.0</version> | ||
| <description>The omg_local_planner package</description> | ||
|
|
||
| <maintainer email="niko@intermodalics.eu">niko</maintainer> |
There was a problem hiding this comment.
Nit: Maintainer should probably be Intermodalics BVBA
| */ | ||
| void publishGlobalPlan(std::vector<geometry_msgs::PoseStamped>& path); | ||
|
|
||
| bool initialized_; |
There was a problem hiding this comment.
Please document member variables.
added 2 commits
March 6, 2018 17:44
| /** | ||
| * @brief goal_reached_srv_ Service name. | ||
| */ | ||
| const std::string compute_velocity_srv_ = "compute_velocity"; |
There was a problem hiding this comment.
Nit: constness can be made more explicit by variable names. Either all caps or kComputeVelocitySrv_ (Google style).
lounick
changed the title
This reverts commit 1fc18f8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created the initial structure. Mostly for review of the code. Requires the services that need to be created in the omg bridge side.