Skip to content

fix: fix lora weight loading for internvl #4106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: fix lora weight loading for internvl #4106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lmdeploy/pytorch/models/internvl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,7 +931,7 @@ def load_lora_weights(self, weights: Iterable[Tuple[str, torch.Tensor]], adapter
else:
from lmdeploy.pytorch.adapter.adapter import load_lora_weights

return load_lora_weights(weights, adapter_id)
return load_lora_weights(self.language_model, weights, adapter_id)

def load_weights(self, weights: Iterable[Tuple[str, torch.Tensor]]):
"""Load weights."""
Expand Down
2 changes: 1 addition & 1 deletion lmdeploy/pytorch/models/internvl3_hf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,7 @@ def load_lora_weights(self, weights: Iterable[Tuple[str, torch.Tensor]], adapter
else:
from lmdeploy.pytorch.adapter.adapter import load_lora_weights

return load_lora_weights(weights, adapter_id)
return load_lora_weights(self.model.language_model, weights, adapter_id)

def rename_weight(self, name: str) -> str:
"""Rename weight."""
Expand Down