[Fix] fix fully_shard offload_policy type inconsistency #1406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix offload_policy type inconsistency (use
OffloadPolicy()instead ofNone) infully_shardOffloadPolicyis a dummy dataclass intorch.distributed.fsdpwhich fits perfectly into the signature offully_shard(the following shows a snippet from torch 2.7.0, other versions likewise):if you use
Noneforoffload_policy, it would work perfectly in runtime, for torch usesisinstance(offload_policy, CPUOffloadPolicy)to determine whether or not to turn on cpu offload (andisinstance(None, CPUOffloadPolicyalways evaluates toFalse). The problem for usingNoneis that it introduces arg-type mismatch for static checkers and makes your life miserable:Using
OffloadPolicyinstead resolves this issue.