Skip to content

[Enhance] add prefetch_factor to DataLoaderConfig #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nil0x9 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Enhance] add prefetch_factor to DataLoaderConfig #1435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions xtuner/v1/datasets/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,7 @@ class DataloaderConfig(BaseDataloaderConfig):
int, Parameter(help="pack extra buffer size when pack_level is expand_soft model")
] = 100
num_workers: Annotated[int, Parameter(help="dataloader num workers")] = 0
prefetch_factor: Annotated[int | None, Parameter(help="number of batches loaded in advance by each worker")] = None
pad_token_id: Annotated[int | None, Parameter(help="padding token id")] = None
tokenizer_hash: Annotated[str | None, Parameter(help="tokenizer hash")] = None

Expand Down Expand Up @@ -431,6 +432,7 @@ def build(
dataset,
batch_size=micro_batch_size,
num_workers=self.num_workers,
prefetch_factor=self.prefetch_factor,
# Ensure to round up or drop last based on the `global_batch_size`,
# if you want to replace a custom sampler.
sampler=sampler,
Expand Down
Loading