[Fix] Fix TypedDict import error for Python < 3.12#1441
Open
nil0x9 wants to merge 1 commit intoInternLM:mainfrom
Open
[Fix] Fix TypedDict import error for Python < 3.12#1441nil0x9 wants to merge 1 commit intoInternLM:mainfrom
nil0x9 wants to merge 1 commit intoInternLM:mainfrom
Conversation
nil0x9
force-pushed
the
linty/dev-fix-typeddict-import
branch
from
893dc26 to
4b9e9b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is complementary to PR https://github.com/InternLM/xtuner/pull
Pydantic requires that
typing_extensions.TypedDIctis used in place oftyping.TypedDIctfor Python < 3.12. So running the current code on earlier Python version will likely thow aPydanticUserErrorSee: https://docs.pydantic.dev/latest/errors/usage_errors/#typed-dict-version