Feature/bindings for dataapps #467
Conversation
HaydarAk
added
enhancement
JohannesLipp
left a comment
JohannesLipp
left a comment
There was a problem hiding this comment.
Please fix the small changes, thanks!
| rdfs:domain ids:App ; | ||
| rdfs:range xsd:string ; | ||
| rdfs:label "app documentation"@en ; | ||
| rdfs:comment "text documentation of the data app"@en ; |
There was a problem hiding this comment.
"of an app". Please also update for the following properties in this file.
|
|
||
| ids:AppType | ||
| a owl:Class; | ||
| rdfs:label "Data app type"@en ; |
There was a problem hiding this comment.
Please remove the term "data" from both label and comment.
clange
left a comment
clange
left a comment
There was a problem hiding this comment.
Looks largely good, but I'd like to request two small changes.
| a owl:DatatypeProperty ; | ||
| rdfs:domain ids:App ; | ||
| rdfs:range xsd:anyURI ; | ||
| rdfs:label "api container spec reference"@en ; |
There was a problem hiding this comment.
"api container": should this read "API container", or (as the names of properties and classes suggest) "app container"?
There was a problem hiding this comment.
@clange This should be "app container spec reference" at this point
| rdfs:comment "Type of an app endpoint. Data apps have different endpoint types, e.g., for input, output or health status."@en ; | ||
| . | ||
|
|
||
| ids:appEndpointPort |
There was a problem hiding this comment.
Am I getting it right that this and other properties will be deleted? If so, please document it in the change log. I think it would make sense to draft these parts of the changelog now already, in a section "next release", as we do not yet know the version number.
DErCouch
left a comment
DErCouch
left a comment
There was a problem hiding this comment.
I see a lot of naming changes within the PR. Maybe rethink the intention about renaming "Data App" to "App". As "Data App" is the logical parent for "Smart-Data-App", "System-Adapter" and "Orchestration-App" the current naming is following a indirect naming convention.
| a owl:DatatypeProperty ; | ||
| rdfs:domain ids:App ; | ||
| rdfs:range xsd:anyURI ; | ||
| rdfs:label "api container spec reference"@en ; |
There was a problem hiding this comment.
@clange This should be "app container spec reference" at this point
No description provided.