RIPE JSON modified and template added#20
Open
MAVRICK-1 wants to merge 1 commit intoInternetHealthReport:mainfrom
Open
RIPE JSON modified and template added#20MAVRICK-1 wants to merge 1 commit intoInternetHealthReport:mainfrom
MAVRICK-1 wants to merge 1 commit intoInternetHealthReport:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made modifications to the code to generate Json file for the RIPE archive data
Date Condition:
As per the provided URL RIPE archive data, the output.json.xz file is available after October 11, 2023. Consequently, I have made two changes to the code based on the date condition.
Depending on the date condition:
URL Reference:
The relevant URL for this operation is [https://ftp.ripe.net/rpki/apnic.tal/).
This modification allows the code to adapt its behavior based on the specified date condition, either generating JSON from a CSV file or uncompressing a specific JSON file.
Here the output for 2018/10/01
only including the output for RIPE ARCHIVE urls
Here the output for 2024/01/01
only including the output for RIPE ARCHIVE urls
This Resolves the issue #19
Added Issue and pull Request template
Issue and pull request templates in GitHub serve as predefined structures for creating new issues or pull requests. They provide a standardized format and set of information that contributors should include when opening issues or submitting pull requests. Here's how they help:
Consistency: Templates ensure that contributors provide essential details in a standardized format. This consistency makes it easier for maintainers to understand the issue or pull request promptly.
Information Gathering: Templates guide users to provide relevant information, such as a clear description, steps to reproduce, or a summary of changes. This reduces back-and-forth communication and helps in faster issue resolution or pull request acceptance.
Reduced Ambiguity: By specifying the information required, templates reduce ambiguity and clarify expectations. This is particularly beneficial when contributors are less familiar with the project or when dealing with complex issues.
Documentation: Templates can include helpful instructions, tips, or links to documentation, making it easier for contributors to navigate the contribution process. This can be especially valuable for new contributors.
Streamlined Workflow: With templates, contributors follow a structured workflow, which simplifies the process of handling issues and pull requests. It ensures that the necessary information is available upfront.
This Solves issue #18
@romain-fontugne can you review my PR :-)