Skip to content

WIP: New TxBodyContent #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Jimbo4350 wants to merge 31 commits into
base: master
Choose a base branch
from
Open

WIP: New TxBodyContent #1011

Jimbo4350 wants to merge 31 commits into from
+3,001 −828

Conversation

@Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Nov 13, 2025 •
edited
Loading

Changelog

- description: |
     In order to move away from the "old" api's `TxBodyContent`  that utilizes the "eon" abstractions and somewhat 
     unnecessarily wrapped data definitions, we introduce a new `TxBodyContent` type that aims to be closer to the 
     ledger's type definitions and therefore easier to use.
  
  type:
  - feature        

  projects:
   - cardano-api

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 13, 2025
View reviewed changes
@Jimbo4350 Jimbo4350 force-pushed the jordan/new-tx-body-content branch 8 times, most recently from debbc9c to 636f91f Compare November 20, 2025 12:35
@Jimbo4350 Jimbo4350 force-pushed the jordan/new-tx-body-content branch 5 times, most recently from 21e5e9c to 86616c5 Compare November 24, 2025 13:26
@Jimbo4350 Jimbo4350 force-pushed the jordan/new-tx-body-content branch 2 times, most recently from 5717284 to 3ba2c0b Compare November 25, 2025 13:35
@Jimbo4350 Jimbo4350 marked this pull request as ready for review November 25, 2025 13:35
@Jimbo4350 Jimbo4350 force-pushed the jordan/new-tx-body-content branch 4 times, most recently from 94916d2 to 87958df Compare November 25, 2025 15:20
@Jimbo4350 Jimbo4350 force-pushed the jordan/new-tx-body-content branch from 2ddbab0 to 39ca061 Compare December 8, 2025 19:46
@Jimbo4350 Jimbo4350 force-pushed the jordan/new-tx-body-content branch from 39ca061 to c24fb9c Compare December 8, 2025 20:24
@Jimbo4350 Jimbo4350 force-pushed the jordan/new-tx-body-content branch from deb5ece to beaddf5 Compare December 9, 2025 14:46
@Jimbo4350 Jimbo4350 force-pushed the jordan/new-tx-body-content branch 2 times, most recently from 92fe16a to 3b5428d Compare December 10, 2025 20:48
@Jimbo4350 Jimbo4350 force-pushed the jordan/new-tx-body-content branch from 3b5428d to 03d69c9 Compare December 10, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carbolymer carbolymer carbolymer left review comments

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@erikd erikd Awaiting requested review from erikd erikd is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara CarlosLopezDeLara is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jimbo4350 @carbolymer