Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Jimbo4350
force-pushed
the
jordan/new-tx-body-content
branch
8 times, most recently
from
debbc9c to
636f91f
Compare
Jimbo4350
force-pushed
the
jordan/new-tx-body-content
branch
5 times, most recently
from
21e5e9c to
86616c5
Compare
Jimbo4350
force-pushed
the
jordan/new-tx-body-content
branch
2 times, most recently
from
5717284 to
3ba2c0b
Compare
Jimbo4350
requested review from
CarlosLopezDeLara,
carbolymer,
dcoutts,
disassembler,
erikd,
kevinhammond,
newhoggy and
palas
as code owners
Jimbo4350
force-pushed
the
jordan/new-tx-body-content
branch
4 times, most recently
from
94916d2 to
87958df
Compare
This was causing incorrect indexing when constructing the redeemer pointer map
Implement HasTypeProxy instances for SLanguage
negative Remove the addition of non-ada tokens in the return collateral
carbolymer
approved these changes
Jan 23, 2026
Contributor
There was a problem hiding this comment.
LGTM! 💪🏻 🚀
Nice work. Let's not postpone too much the issues which came from this work however i.e. #1084
Also small thing: https://github.com/IntersectMBO/cardano-api/pull/1011/files#r2711423979
| hashAnyScript (AnyPlutusScript ps) = | ||
| hashPlutusScriptInEra ps | ||
|
|
||
| deserialiseAnySimpleScript |
Contributor
There was a problem hiding this comment.
why a separate function instead of SerialiseAsCBOR instance?
Contributor
Author
There was a problem hiding this comment.
I don't have a good answer. We use a JSON representation for simple scripts but I agree we should have the relevant instance: #1088
Comment on lines
+37
to
+38
| data UnsignedTx era | ||
| = L.EraTx (LedgerEra era) => UnsignedTx (Ledger.Tx (LedgerEra era)) |
Contributor
There was a problem hiding this comment.
We should be using ledger eras as an era type parameter instead of cardano-api's eras.
Contributor
Author
There was a problem hiding this comment.
I agree. I want to also use UnsignedTx in the compatibility code: #1089
Refactor of Eq instance
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist