Skip to content

Do not merge: Remove makeShelleyTransactionBody and accompanying functions#1094

Open
Jimbo4350 wants to merge 1 commit intomasterfrom
jordan/remove-makeShelleyTransactionBody
Open

Do not merge: Remove makeShelleyTransactionBody and accompanying functions#1094
Jimbo4350 wants to merge 1 commit intomasterfrom
jordan/remove-makeShelleyTransactionBody

Conversation

@Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Jan 28, 2026

Changelog

- description: |
    Remove `makeShelleyTransactionBody` and accompanying functions

  type:
   - breaking    
  projects:
   - cardano-api

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 changed the title Remove makeShelleyTransactionBody and accompanying functions Do not merge: Remove makeShelleyTransactionBody and accompanying functions Jan 28, 2026
@Jimbo4350
Copy link
Contributor Author

Wait till 11.0.0.0 release

Copilot AI review requested due to automatic review settings March 12, 2026 14:41
@Jimbo4350 Jimbo4350 force-pushed the jordan/remove-makeShelleyTransactionBody branch from 9f5cf5c to 3d69175 Compare March 12, 2026 14:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes deprecated Shelley-era transaction body construction APIs from cardano-api, consolidating callers onto createTransactionBody as the supported entry point.

Changes:

  • Removed createAndValidateTransactionBody from public exports and deleted its implementation.
  • Removed deprecated makeShelleyTransactionBody and the now-unneeded validateTxBodyContent helper plus related era imports.
  • Updated the typed test generator to use createTransactionBody.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
cardano-api/src/Cardano/Api/Tx/Internal/Body.hs Drops deprecated tx body builders/validators and associated imports.
cardano-api/src/Cardano/Api/Tx.hs Removes createAndValidateTransactionBody from the public Cardano.Api.Tx export surface.
cardano-api/gen/Test/Gen/Cardano/Api/Typed.hs Switches tx body generation to createTransactionBody.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants