Make maxIterations injectable to test FeeCalculationDidNotConverge#1119
Draft
Make maxIterations injectable to test FeeCalculationDidNotConverge#1119
maxIterations injectable to test FeeCalculationDidNotConverge#1119Conversation
3 tasks
…vergence failure test Co-authored-by: carbolymer <228866+carbolymer@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update recursive minimum fee calculation implementation
Make Mar 6, 2026
maxIterations injectable to test FeeCalculationDidNotConverge
Base automatically changed from
jordan/introduce-calculate-min-fee-recursive
to
master
March 9, 2026 16:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
FeeCalculationDidNotConvergeerror path incalcMinFeeRecursivewas untestable without a transaction that genuinely fails to converge in 50 iterations (practically impossible with realistic protocol parameters).Changes
Fee.hs: Extracted the implementation intocalcMinFeeRecursiveWith :: Int -> ...where theIntis the iteration limit.calcMinFeeRecursivebecomes a one-liner delegating tocalcMinFeeRecursiveWith 50. ExportedcalcMinFeeRecursiveWithunder-- Internal.Test/Cardano/Api/Experimental.hs: Addedprop_calcMinFeeRecursive_did_not_converge— callscalcMinFeeRecursiveWith 1on a well-funded zero-fee transaction. The single iteration advances the fee (Case 3) and the counter hits 0 on the recursive call, deterministically returningFeeCalculationDidNotConverge.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.