Shelley: export {to,from}AlonzoLanguage (Plutus script language conversions)#731
Merged
Shelley: export {to,from}AlonzoLanguage (Plutus script language conversions)#731
Conversation
carbolymer
reviewed
Jan 20, 2025
Comment on lines
+140
to
+141
| , toAlonzoLanguage | ||
| , fromAlonzoLanguage |
Contributor
There was a problem hiding this comment.
I think we should replace those two function with Inject instances.
Contributor
Author
There was a problem hiding this comment.
@carbolymer> I disagree, I think we should keep Inject for conversions between eons; otherwise upon seeing a call to inject in the code we won't easily know what it's about.
Contributor
There was a problem hiding this comment.
That's not what is Inject for in general. It's used widely in ledger codebase for conversion between isomorphic types.
Contributor
Author
There was a problem hiding this comment.
@carbolymer> is the ledger a model codebase in terms of ease-of-understanding 😉?
49f3ce6 to
2430f57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Required to adapt
cardano-nodeto #729Checklist