Skip to content

Conversation

@smelc
Copy link
Contributor

@smelc smelc commented Nov 19, 2024

Changelog

- description: |
    Share code between `genesis` commands and `create-testnet-data`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

  1. This is a small QoL improvement on its own.
  2. And it's further built upon by create-testnet-data: create byron genesis #974

How to trust this PR

  • I have run cardano-testnet tests with this PR.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/genesis-share-writing-code branch from ed4444d to ffd78dc Compare November 19, 2024 12:36
@smelc smelc force-pushed the smelc/genesis-share-writing-code branch from ffd78dc to 059da05 Compare November 19, 2024 12:44
@smelc smelc marked this pull request as ready for review November 19, 2024 12:44
@smelc smelc added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@smelc smelc added this pull request to the merge queue Nov 20, 2024
Merged via the queue into master with commit 816768e Nov 20, 2024
29 checks passed
@smelc smelc deleted the smelc/genesis-share-writing-code branch November 20, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants