Skip to content

create-testnet-data's implementation: explain why drepDelegs can be left empty #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smelc merged 1 commit into from
Dec 11, 2024
Merged

create-testnet-data's implementation: explain why drepDelegs can be left empty #991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cardano-cli/src/Cardano/CLI/EraBased/Run/Genesis/CreateTestnetData.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,9 @@ runGenesisCreateTestNetDataCmd
{ L.drepExpiry = EpochNo 1_000
, L.drepAnchor = SNothing
, L.drepDeposit = max (L.Coin 1_000_000) minDeposit
, L.drepDelegs = Set.empty
, L.drepDelegs = Set.empty -- We don't need to populate this field (field "initialDReps"."keyHash-*"."delegators" in the JSON)
Copy link
Contributor

@Jimbo4350 Jimbo4350 Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the actual explanation from Alexy here and also confirm if the `"delegators" field will be removed?
Linking to the actual issue would be better: IntersectMBO/cardano-ledger#4782 (comment)

-- because its content is derived from the "delegs" field ("cgDelegs" above)
-- More context is provided here: https://github.com/IntersectMBO/cardano-cli/pull/987
}
)
)
Expand Down
Loading