1843 - limit cache when close to tip #1886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cmdv
force-pushed
the
1843-limit-cache-at-tip
branch
4 times, most recently
from
73a8fa6 to
34bceb6
Compare
kderme
requested changes
Nov 25, 2024
Contributor
kderme
left a comment
kderme
left a comment
There was a problem hiding this comment.
optimiseCaches requires fixing.
Also optomise is sometimes used instead of optimise. Using reduce instead of optimise would also make it more specific, since the cache is reduced.
Finally, using patterns as suggested could reduce the cases.
Cmdv
force-pushed
the
1843-limit-cache-at-tip
branch
from
46a3f01 to
54fcebb
Compare
Cmdv
force-pushed
the
1843-limit-cache-at-tip
branch
from
54fcebb to
a28f1de
Compare
kderme
requested changes
Nov 27, 2024
Contributor
kderme
left a comment
kderme
left a comment
There was a problem hiding this comment.
possibly the new boolean flag need to become a TVar
kderme
reviewed
Nov 28, 2024
Contributor
kderme
left a comment
kderme
left a comment
There was a problem hiding this comment.
Just a few stylistic changes and this is good to go
Cmdv
force-pushed
the
1843-limit-cache-at-tip
branch
from
1db8911 to
26346a2
Compare
kderme
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #1843
Checklist
fourmoluon version 0.10.1.0 (which can be run withscripts/fourmolize.sh)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.