Fix queryOutput* database value to Ada conversions #2037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expression `lovelaceToAda. MkFixed . fromIntegral` incorrectly places the decimal point 12 spaces from the RH end instead of 6 places. Removing the `MkFixed` portion fixes the conversion. Closes: #2031
The old version of this function had type `Micro -> Ada`, but that type allowed its use in `lovelaceToAda . MkFixed . fromIntegral` AND as `lovelaceToAda . fromIntegral` with the former giving INCORRECT results. By switching the type to `Integer -> Ada` it is no longer possible to use this function incorrectly. Related: #2031
Cmdv
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The expression
lovelaceToAda. MkFixed . fromIntegralincorrectly places the decimal point 12 spaces from the RH end instead of 6 places. Removing theMkFixedportion fixes the conversion.Also change the type of
lovelaceToAdaso it cannot be used incorrectly.Checklist
fourmoluon version 0.17.0.0 (which can be run withscripts/fourmolize.sh)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.