Improve ImpTest helpers
#5220
Draft
Improve ImpTest helpers
#5220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Lucsanszky
force-pushed
the
ldan/imptest-improvements
branch
2 times, most recently
from
a18f850 to
039ac1e
Compare
It is not required by the `STS (ShelleyPOOL)` instance
* Decouple `ConwayEraTxCert` from `ShelleyEraTxCert` * Remove `ShelleyEraTxCert` from `ShelleyEraImp` and `ConwayEraTxCert` from `ConwayEraImp` These should not constrain `EraImp`s for the same reason they don't constrain `EraTest`s. See #4992 * Make some Conway `ImpTest` helpers era generic by only using certificates with deposits
* Generalise compatible tests by using certificates with deposits * Move tests that are reliant on certs w/out deposits and only run them pre-Dijkstra
* Move tests that are reliant on certs w/out deposits and only run them pre-Dijkstra
* Move tests that are reliant on certs w/out deposits and only run them pre-Dijkstra
Co-authored-by: Alexey Kuleshevich <[email protected]>
Without this, users won't be able to change their delegation without unregistration. Also, re-organise some tests again and run them in each era if they are general enough (i.e not dependent on Shelley style certs). Co-authored-by: Alexey Kuleshevich <[email protected]>
Co-authored-by: Alexey Kuleshevich <[email protected]>
* Move tests that are reliant on certs w/out deposits and only run them pre-Dijkstra
Lucsanszky
force-pushed
the
ldan/imptest-improvements
branch
from
039ac1e to
2997716
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).