Skip to content

Run Imp DELEG tests across eras #5330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 13, 2025
Merged

Run Imp DELEG tests across eras #5330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
639d15a
Add `ShelleyEraImp` method to delegate stake across eras
teodanciu Oct 3, 2025
3fac44c
Make some conway `DelegSpec` tests compatible with earlier eras
teodanciu Oct 3, 2025
8464bf5
Extract stake registration and delegation utility functions to `ImpTest`
teodanciu Oct 3, 2025
776956c
Move DELEG tests compatible with previous eras to new shelley`DelegSpec`
teodanciu Oct 3, 2025
b065c65
Add shelley-specific DELEG tests
teodanciu Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion eras/allegra/impl/testlib/Test/Cardano/Ledger/Allegra/Imp.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@ spec = do
describe "AllegraImpSpec" . withEachEraVersion @era $
UtxowSpec.spec

instance EraSpecificSpec AllegraEra
instance EraSpecificSpec AllegraEra where
eraSpecificSpec = ShelleyImp.shelleyEraSpecificSpec
1 change: 1 addition & 0 deletions eras/allegra/impl/testlib/Test/Cardano/Ledger/Allegra/ImpTest.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ instance ShelleyEraImp AllegraEra where
modifyImpInitProtVer = shelleyModifyImpInitProtVer
genRegTxCert = shelleyGenRegTxCert
genUnRegTxCert = shelleyGenUnRegTxCert
delegStakeTxCert = shelleyDelegStakeTxCert

impAllegraSatisfyNativeScript ::
( ShelleyEraImp era
Expand Down
4 changes: 3 additions & 1 deletion eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/Imp.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import qualified Test.Cardano.Ledger.Alonzo.Imp.UtxowSpec as Utxow
import Test.Cardano.Ledger.Alonzo.ImpTest
import Test.Cardano.Ledger.Imp.Common
import qualified Test.Cardano.Ledger.Mary.Imp as MaryImp
import qualified Test.Cardano.Ledger.Shelley.Imp as ShelleyImp

spec ::
forall era.
Expand All @@ -40,4 +41,5 @@ alonzoEraSpecificSpec = do
Utxow.alonzoEraSpecificSpec

instance EraSpecificSpec AlonzoEra where
eraSpecificSpec = alonzoEraSpecificSpec
eraSpecificSpec =
ShelleyImp.shelleyEraSpecificSpec >> alonzoEraSpecificSpec
1 change: 1 addition & 0 deletions eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/ImpTest.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,7 @@ instance ShelleyEraImp AlonzoEra where
modifyImpInitProtVer = shelleyModifyImpInitProtVer
genRegTxCert = shelleyGenRegTxCert
genUnRegTxCert = shelleyGenUnRegTxCert
delegStakeTxCert = shelleyDelegStakeTxCert

instance MaryEraImp AlonzoEra

Expand Down
3 changes: 2 additions & 1 deletion eras/babbage/impl/testlib/Test/Cardano/Ledger/Babbage/Imp.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import qualified Test.Cardano.Ledger.Babbage.Imp.UtxosSpec as Utxos
import qualified Test.Cardano.Ledger.Babbage.Imp.UtxowSpec as Utxow
import Test.Cardano.Ledger.Babbage.ImpTest (BabbageEraImp)
import Test.Cardano.Ledger.Imp.Common
import qualified Test.Cardano.Ledger.Shelley.Imp as ShelleyImp

spec :: forall era. (BabbageEraImp era, EraSpecificSpec era) => Spec
spec = do
Expand All @@ -28,4 +29,4 @@ spec = do

instance EraSpecificSpec BabbageEra where
eraSpecificSpec =
AlonzoImp.alonzoEraSpecificSpec
ShelleyImp.shelleyEraSpecificSpec >> AlonzoImp.alonzoEraSpecificSpec
1 change: 1 addition & 0 deletions eras/babbage/impl/testlib/Test/Cardano/Ledger/Babbage/ImpTest.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ instance ShelleyEraImp BabbageEra where
modifyImpInitProtVer = shelleyModifyImpInitProtVer
genRegTxCert = shelleyGenRegTxCert
genUnRegTxCert = shelleyGenUnRegTxCert
delegStakeTxCert = shelleyDelegStakeTxCert

babbageFixupTx ::
( HasCallStack
Expand Down
7 changes: 3 additions & 4 deletions eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,9 @@ conwayEraGenericSpec = do

conwayEraSpecificSpec :: SpecWith (ImpInit (LedgerSpec ConwayEra))
conwayEraSpecificSpec = do
describe "Conway era specific Imp spec" $
describe "Certificates without deposits" $ do
describe "DELEG" Deleg.conwayEraSpecificSpec
describe "UTXO" Utxo.conwayEraSpecificSpec
describe "Conway era specific Imp spec" $ do
describe "DELEG" Deleg.conwayEraSpecificSpec
describe "UTXO" Utxo.conwayEraSpecificSpec

instance EraSpecificSpec ConwayEra where
eraSpecificSpec =
Expand Down
Loading