Skip to content

Shelley: Move withdrawals draining from DELEGS to LEDGER #5341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Shelley: Move withdrawals draining from DELEGS to LEDGER #5341

wants to merge 1 commit into from
+40 −34

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Oct 16, 2025 •
edited
Loading

Description

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@aniketd
Move withdrawals-draining from DELEGS to LEDGER.
6b22c6f 
* Remove `WIthdrawalsNotInRewardsDELEGS` pred-failure.
* Add `ShelleyWithdrawalsMissingAccounts` and
  `ShelleyIncompleteWithdrawals` to `ShelleyLedgerPredFailure`.
@aniketd aniketd force-pushed the aniketd/shelley-withdrawals branch from 551ba54 to 6b22c6f Compare October 16, 2025 13:05
@aniketd aniketd marked this pull request as ready for review October 16, 2025 13:06
@aniketd aniketd requested a review from a team as a code owner October 16, 2025 13:06
neilmayhew
neilmayhew reviewed Oct 16, 2025
View reviewed changes
Copy link
Contributor

@neilmayhew neilmayhew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume there should be a CDDL change that goes along with this.

eras/shelley/impl/src/Cardano/Ledger/Shelley/Rules/Delegs.hs
Comment on lines +205 to +208
( env@(DelegsEnv slot@(SlotNo slot64) epochNo txIx pp _tx chainAccountState)
, certState
, certificates
) <-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation seems off here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neilmayhew neilmayhew neilmayhew left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aniketd @neilmayhew