Added custom generator to address, enabled some Huddle tests #5505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
force-pushed
the
jj/custom-generators
branch
4 times, most recently
from
b07eb66 to
b0ca63b
Compare
Soupstraw
changed the title
Soupstraw
force-pushed
the
jj/custom-generators
branch
3 times, most recently
from
216f332 to
19cec52
Compare
Soupstraw
force-pushed
the
jj/custom-generators
branch
2 times, most recently
from
f2589a9 to
512a628
Compare
lehins
requested changes
Jan 8, 2026
libs/cardano-ledger-core/cddl/Cardano/Ledger/Core/HuddleSpec.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/cddl/Cardano/Ledger/Core/HuddleSpec.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/cddl/Cardano/Ledger/Core/HuddleSpec.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/cddl/Cardano/Ledger/Core/HuddleSpec.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/cddl/Cardano/Ledger/Core/HuddleSpec.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/cddl/Cardano/Ledger/Core/HuddleSpec.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/cddl/Cardano/Ledger/Core/HuddleSpec.hs
Outdated
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/custom-generators
branch
from
512a628 to
9614b6a
Compare
Soupstraw
force-pushed
the
jj/custom-generators
branch
from
501a2c3 to
8f52c71
Compare
lehins
approved these changes
Jan 31, 2026
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Very nice! Thank you.
This will probably need to be adjusted when we start using cuddle version that uses QuickCheck's Gen, instead of StatefulGen, but compiler will remind us about it.
Collaborator
|
Needs a manual rebase due to some conflicts not visible in Github UI |
Soupstraw
force-pushed
the
jj/custom-generators
branch
2 times, most recently
from
eeaa5ff to
5bd82f5
Compare
lehins
force-pushed
the
jj/custom-generators
branch
from
5dfe1fd to
828a346
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds custom generators to
addressandreward_account, which allows us to enable some Huddle roundtrip tests.Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).