-
Notifications
You must be signed in to change notification settings - Fork 175
Introduce CanonicalCoin type
#5552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR is based on top of the #5548 and is intended to be merged and reviewed after that one |
2935352 to
e8a773b
Compare
|
I've prepared a commit for the next namespace, interesting and discussible thing here is introducing I could adopt the code to the approach chosen by the project. |
lehins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pots is not a type that is needed for ledger state validation. Moreover, its contents can fully be derived from the rest of the ledger state. So, it has no place in the canonical ledger state
libs/cardano-ledger-canonical-state/src/Cardano/Ledger/CanonicalState/BasicTypes.hs
Outdated
Show resolved
Hide resolved
0d4f0fc to
12fb427
Compare
|
I've removed |
lehins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
New namespace, that follows the same patterns as utxo and blocks namespace.
12fb427 to
ba1531c
Compare
CanonicalCoin type
Description
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).